-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wren-ui): Epic intention + recommend question #876
Draft
onlyjackfrost
wants to merge
24
commits into
main
Choose a base branch
from
epic/intension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwy3y3
changed the title
feat(wren-ui): Epic intension + recommend question
feat(wren-ui): Epic intention + recommend question
Nov 10, 2024
…ement the graphql query to get the project recommend questions
- update returning recommend question data structure.
fredalai
force-pushed
the
epic/intension
branch
from
November 13, 2024 04:35
5c66cef
to
f86994d
Compare
- move the type definition to /models to avoid "ReferenceError: Cannot access 'IbisAdaptor' before initialization "
wwwy3y3
reviewed
Nov 15, 2024
Comment on lines
+390
to
+398
const tasks = this.threadRecommendQuestionBackgroundTracker.getTasks(); | ||
const taskKey = | ||
this.threadRecommendQuestionBackgroundTracker.taskKey(thread); | ||
if (tasks[taskKey]) { | ||
logger.debug( | ||
`thread "${threadId}" recommended questions are generating, skip the current request`, | ||
); | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you could implement a method like: getTask
or ifExists
to check the existence of task with thread id.
wwwy3y3
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL
Query getThreadRecommendationQuestions
Query getProjectRecommendationQuestions
There are 4 kinds of status in getThreadRecommendationQuestions & getProjectRecommendationQuestions.
NOT_STARTED
- There are no recommended questions, and no pipeline is performing the recommendation action.GENERATING
- There is a pipeline performing the recommendation action, fetch again later to get the recommendation.FINISHED
- The pipeline finished the recommendation actionERROR
- The pipeline encounters error and can not finished the task.Mutation generateProjectRecommendationQuestions
Mutation generateThreadRecommendationQuestions
Screenshots
generateThreadRecommendationQuestions
getThreadRecommendationQuestions- NOT_STARTED
getThreadRecommendationQuestions- GENERATING
getThreadRecommendationQuestions- FINISHED
getProjectRecommendationQuestions-GENERATING
getProjectRecommendationQuestions-FINISHED
generateProjectRecommendationQuestions