Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wren-ui): add event to record ibis performance #823

Merged

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Oct 24, 2024

The ibis server in the Wren Engine provide the response with headers X-Correlation-ID and X-Process-Time by Canner/wren-engine#836.
We can log them via Posthog.
Also, add events ibis_query and ibis_dry_run.

@grieve54706 grieve54706 force-pushed the grieve/feature/send-more-ibis-event branch from 185e488 to 5c8b13c Compare October 24, 2024 10:39
@grieve54706
Copy link
Contributor Author

grieve54706 commented Oct 30, 2024

Hi @wwwy3y3, @onlyjackfrost. Could you check this PR?

@grieve54706 grieve54706 force-pushed the grieve/feature/send-more-ibis-event branch from ea50169 to ce32fcb Compare October 30, 2024 05:57
Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grieve54706 grieve54706 deleted the grieve/feature/send-more-ibis-event branch October 30, 2024 07:16
@grieve54706 grieve54706 restored the grieve/feature/send-more-ibis-event branch October 30, 2024 07:18
@grieve54706 grieve54706 reopened this Oct 30, 2024
@onlyjackfrost onlyjackfrost changed the title feat(posthog): add more event for ibis chore(wren-ui): add more event for ibis Oct 30, 2024
@onlyjackfrost onlyjackfrost changed the title chore(wren-ui): add more event for ibis chore(wren-ui): add event to record ibis performance Oct 30, 2024
@onlyjackfrost onlyjackfrost merged commit 1860cf8 into Canner:main Oct 30, 2024
3 checks passed
@grieve54706 grieve54706 deleted the grieve/feature/send-more-ibis-event branch November 1, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants