Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/small refinements to launcher #269

Merged
merged 4 commits into from
May 20, 2024
Merged

chore/small refinements to launcher #269

merged 4 commits into from
May 20, 2024

Conversation

cyyeh
Copy link
Member

@cyyeh cyyeh commented May 19, 2024 •
edited
Loading

  • use the repo's docker compose yaml and .env.example file
  • change docker compose yaml env part in wren-ui service
  • add instruction to adding open ai key

@cyyeh cyyeh requested a review from wwwy3y3 May 19, 2024 02:40
@cyyeh cyyeh changed the title fix missing envs to posthog chore/small refinements to launcher May 19, 2024
@cyyeh cyyeh force-pushed the chore/launcher/fix-missing-envs branch 2 times, most recently from 47cc95d to 2c2e119 Compare May 19, 2024 23:26
@cyyeh cyyeh force-pushed the chore/launcher/fix-missing-envs branch from 2c2e119 to 73687f6 Compare May 20, 2024 01:18
wwwy3y3
wwwy3y3 requested changes May 20, 2024
View reviewed changes
Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyyeh Missing following configs in docker-compose file

In wren-ai service

ports: 
  - ${AI_SERVICE_FORWARD_PORT}:${WREN_AI_SERVICE_PORT}

In wren-ui service, missing following env

WREN_ENGINE_PORT: ${WREN_ENGINE_PORT}

wwwy3y3
wwwy3y3 approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@wwwy3y3 wwwy3y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwwy3y3 wwwy3y3 merged commit 1fac9b7 into main May 20, 2024
2 checks passed
@wwwy3y3 wwwy3y3 deleted the chore/launcher/fix-missing-envs branch May 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwy3y3 wwwy3y3 wwwy3y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyyeh @wwwy3y3