Skip to content

fix: add missing quotes around column names in relation conditions #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add missing quotes around column names in relation conditions #1858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d704246
fix: add missing quotes around column names in relation conditions
Mirza-Samad-Ahmed-Baig Aug 2, 2025
d41103a
Merge branch 'main' into fix-relation-condition-column-quotes
Mirza-Samad-Ahmed-Baig Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wren-ui/src/apollo/server/mdl/mdlBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ export class MDLBuilder implements IMDLBuilder {
//TODO phase2: implement the expression for relation condition
const { fromColumnName, toColumnName, fromModelName, toModelName } =
relation;
return `"${fromModelName}".${fromColumnName} = "${toModelName}".${toColumnName}`;
return `"${fromModelName}"."${fromColumnName}" = "${toModelName}"."${toColumnName}"`;
}

private buildTableReference(model: Model): TableReference | null {
Expand Down