Convert some providers to interfaces.#129
Convert some providers to interfaces.#129jamierocks wants to merge 1 commit intoCanaryModTeam:masterfrom jamierocks:fix/providers
Conversation
Only the providers that are for vanilla features have been converted, as I see no reason why any implementation would want to change the way the others are handled. This allows CanaryLib to be implemented on Forge, and have whitelist and op working :)
|
Is there a working impl of this for CanaryMod? |
|
No. |
|
Hmm. Lets put it this way. Like CanaryDefaultThingyProvider implements ... {blah blah} VanillaThingyProvider implements ... {blah blah} [...]snip Somewhere in bootstrapping: This way it should as well be possible to inject a default forge-specific behaviour. |
|
That would be best. It would not force any real change in any impl using the lib. |
|
Is it not, just easier to move it into CanaryMod? This seems like a lot of effort, when I can use Mixins... |
|
No because these providers pertain to the data backends which are, by default, provided by canary. |
Only the providers that are for vanilla features have been converted, as I see no reason why any implementation would want to change the way the others are handled.
This allows CanaryLib to be implemented on Forge, and have whitelist and op working :)