Skip to content

Port to 1.21#4

Merged
CamperSamu merged 0 commit intoCamperSamu:1.21.1from
unilock:1.21
Sep 18, 2024
Merged

Port to 1.21#4
CamperSamu merged 0 commit intoCamperSamu:1.21.1from
unilock:1.21

Conversation

@unilock
Copy link
Contributor

@unilock unilock commented Sep 16, 2024

This PR ports PolyForgery to 1.21(.1).

Also:

  • All textures have been optimized with oxipng, making them a bit smaller
  • Polydex support is still present
  • Tier Override information is now visible in the Polydex recipes (i.e. higher tier Alloy Forges sometimes have a higher yield; this is now presented in the Polydex recipe)
  • Various things have been cleaned up

@CamperSamu
Copy link
Owner

CamperSamu commented Sep 18, 2024

Thanks for the PR!
I am merging this manually ASAP rebasing on your tree, pushing everything after building and testing.

Since serverside modding is going more and more mainstream, I am also planning to ship this mod to Modrinth (after ages, I know), I'll make sure to add you as a contributor (as well as any major contributors from the past)

@unilock
Copy link
Contributor Author

unilock commented Sep 18, 2024

Ah, one thing I forgot to fix is that sgui needs to be jar-in-jar'd (include(...)), since it's not present in any of the dependencies of PolyForgery.

@CamperSamu
Copy link
Owner

Fixed it, thanks for the heads up
The only issue I noticed is a client failure when building the multiblock, it disconnects with "No value with id 44" so I think that PolyMc is not blocking everything correctly.
This will probably be gone when PolyMc releases since 1.21 is still WIP, so I'll ignore it for now

@CamperSamu CamperSamu merged commit 16aec95 into CamperSamu:1.21.1 Sep 18, 2024
@CamperSamu
Copy link
Owner

Manually merged your patches and force-pushed the new up-to-date tree to the 1.21.1 branch, thanks again!

@CamperSamu
Copy link
Owner

Release out on GitHub: v2.1.0+1.21.1 - Update to 1.21.1, Compressed Textures and Polydex is back!
Waiting for TheEpicBlock/PolyMc v5.7.0 for the Modrinth release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants