Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to exclude user/bot avatars from file encryption #121

Merged

Conversation

crispyross
Copy link
Contributor

Adds an option (Common.encryptAvatars in src/common.js) for whether to include or exclude user/bot avatars in the file encryption system used in Common.mkAndWrite. This allows for serving the avatar images with a plain HTTP server rather than having to involve middleware to decrypt them.

Copy link
Owner

@CampbellCrowley CampbellCrowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I totally forgot about this, thanks for adding this in!

I had thrown data encryption in very quickly because I am required to have it by the Discord TOS for "API Data". However it's a little confusing on whether avatars or NPC images fall under the category of "API Data" as they come from their CDN.
link to TOS TOS Definitions

Any thoughts before merging?

@crispyross
Copy link
Contributor Author

I would argue that avatars are public info since they're chosen by the user to always be displayed next to them, and are hosted from their CDN, as you said. But I didn't really think about TOS when I made this change -- it was just something useful for self-hosting that I shared.

I'll leave the choice up to you whether you want to merge this option, and feel free to change the default setting to encrypted.

@CampbellCrowley CampbellCrowley merged commit fb09b66 into CampbellCrowley:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants