CaptureImage doesn't work most of the time on android

[Tsabary]

Is this a bug report?

(write your answer here)
Yes

Have you read the Contributing Guidelines?

Yes
(Write your answer here.)

Environment

Android Studio emulator / OnePlus 5t

Steps to Reproduce

(Write your steps here:)

1. Implement captureImage
2. Try to take a photo

Expected Behavior

(Write what you thought would happen.)

A photo would be taken

Actual Behavior

(Write what happened. Add screenshots!)

The action doesn't kick in at all. I've entered a few Logs, the first being immedietly after calling to capture image, but whenever that issue exists (which is almost always for me both at the emulator and OnePlus device, that Log never prints.

Reproducible Demo

https://stackoverflow.com/questions/55526362/capture-image-action-only-works-sometimes-without-clear-reason-why

You could see here the relevant part of the code. The log that should print "image captured" almost never prints (and a photo isn't taken). When a photo is taken, the log of course prints, but there is no reasoning behind when it would or wouldn't work. It seems that it is more likely to work on the emulator.

[drogeek]

I've the same problem and have noticed it would take a picture if I obstruct the lens with for instance my finger.

[Tsabary]

It wouldn't be a good solution, but it doens't work for me anyway.
I've been pushing this fix to the end because I really want to avoid changing to Fotoapparat (moved it from there to CameraKit before), but looks like I'll have to. Really hoping for an update soon that'll fix it.

[Akshshr]

Yes, noticing the same...CaptureImage doesnt do anything at least on
1.0.0-beta3.11'

[Tsabary]

is there a previous version in which you know it did work? I don't mind downgrading for now, my camera request is super simple

[arsenii-repository]

Experiencing same problem. Anyone have forced CameraKit work properly?

@Tsabary I also moved from Fotoapparat to CameraKit in hope it will work. (Fotoapparat seems doesn't work on API 17)

[austinkettner]

Hey guys, can you be more specific about the versions of CK you are using? This isn't a known widespread issue but obviously is affecting you. We will look into it once we know more!

[arsenii-repository]

build.gradle

    implementation 'com.camerakit:camerakit:1.0.0-beta3.11'
    implementation 'com.camerakit:jpegkit:0.1.0'
    implementation 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.0'
    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.0.0'

Also no errors/info in logcat. No error in CameraKitView.ErrorListener.

[Akshshr]

Here are my details
Gradle

 implementation 'com.camerakit:camerakit:1.0.0-beta3.10'
    implementation 'com.camerakit:jpegkit:0.1.0'
    implementation 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.0'
    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.0.0'

I think the root of a lot of these issues are that the sample app has very deprecated code. Would be nice to have that on V1

[Tsabary]

I am using 3.11 now but the problem still existed when i was on 3.10.

I am running my app on the emulator and on a OnePlus 5t.

This is how my code is structured:

 captureButton.setOnClickListener {

        Log.d("photoActivity", "button clicked")

        cameraKitView.captureImage(){ _, p1 ->
            Log.d("photoActivity", "image captured")
    }
}

I've also tried instead of captureImage() to have it captureImage or captureFrame. The current setp seems to be the most consistent and I was just able to make it work with my OnePlus as well (literally for the first time as I was writing this) but it is still not consistent.

button clicked is always printed, where image captured almost never does (it rarely happens and inly on the emulator).

[Tsabary]

Update: as per Murphy's law, things might actually be working for me now. It seems to be more consistent after I've added the empty brackets. I am still running tests but it is deffinitely working much better than it did before.

[Tsabary]

Update: it stops working again. I can't get it to be stable.
Before calling it an issue, I think it would be best if you can provide with the proper way to capture an image using Kotlin, because currently I can't tell if it is nor consistent because of the library or because I am doing something wrong (though I have tried quit a few different options)

[Uplink03]

I was trying to debug this, but Android Studio claimed that the bytecode didn't match the source code for CameraKitView, so I've cloned branch v1.0.0-beta4, added the camerakit directory to my project and, with some effort, made it build as a subproject just like the demo app does in this repository instead of using the pre-built release.

Good news: with the integrated project this works. So my guess is that the published build is out of date.

I'm not sure I'd be able to tell you how I did the subproject integration, as it was quite a bit of trial and error (I'm new to Android development), using the gradle files in this repository as reference each time I had an error.

[leokvw]

Same problem here in my Google Pixel 1. I have implemented the captureImage function as instructed and Logcat didn't print anything strange...and that's strange hhhh.