Fix BlurLayout#setAlpha(float) & Closes #41 #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fung Gwo <fython@163.com>
Merged
|
Hey @fython I wanted to follow up on your PR. We are not sure of our future plans for the BlurKit project quite yet. To avoid the need for licensing agreements we aren’t going to merge your changes directly. We have resolved your concerns in our latest PR #45. We really appreciate your contributions as it did help contribute to our PR, so definitely PR going forward as it’s a great way to get changes integrated directly =) |
|
@emersoncloud You're welcome. This project helps me a lot and the bug has been fixed in time so I am grateful too. If we have a chance to contribute code again, you could ask me what you want to know directly, such as license aggrement, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug by adding
mLockedAlphafield to save the actual value of alpha.I also added an alpha animation demo in sample app module.