Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent memory leaks and improve performance #39

Closed
wants to merge 2 commits into from

Conversation

PaulWoitaschek
Copy link

  • In case someone passes an activity, we need to make sure we are using the application context.
  • In case there is no downscaleFactor set, we don't need to apply a matrix to the canvas

@austinkettner
Copy link
Member

@PaulWoitaschek Thanks for submitting this! We are debating how to handle PRs going forward, for example we are thinking about potentially requiring CLAs to be signed.

Will get this wrapped in the next day or two and your changes merged in!

@emersoncloud emersoncloud mentioned this pull request Nov 1, 2018
@emersoncloud
Copy link
Contributor

Hey Paul I wanted to follow up on what Austin mentioned earlier. We are not sure of our future plans for the BlurKit project quite yet. To avoid the need for licensing agreements we aren’t going to merge your changes directly. We have resolved your concerns in our latest PR #45. We really appreciate your contributions as it did help contribute to our PR, so definitely PR going forward as it’s a great way to get changes integrated directly =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants