Dark mode for PDF #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image mask is now SKPath, not bitmap. Darkmode rendering is now in Utilities/DarkModeRender so there is no redundant code for thumbnails and pages
Darkmode added to actual version of app
rester images are now non-inverted on all pages
|
@ihonza thanks a lot for the PR! I really like the idea. I'll find time to review it shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a button (feel free to move it is its against GUI styling) that toggles PDF view between bright and dark. Bright is normal as it was, but dark inverts HSV lightness of everything except raster images (all images Page.GetImages returns). It uses only SkiaSharp for graphics and I hope that variables are where they belong. I did my best to stick with the style and architecture of the project. Feel free to contact me if you have any questions!