Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong-name all Assemblies #704

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

willson556
Copy link
Contributor

Possible solution to #700
Tweaks for consistent strong-naming.
Also, reduced the number of targets required.

@willson556
Copy link
Contributor Author

Because of the viral nature of strong-naming, it is recommended that publicly published .NET libraries are strong-named. Not strong-naming a .NET library excludes anyone who does need to strong-name their application or library from using it. Read more about .NET libraries and strong-naming in the .NET Library Guidance.
Source: https://github.com/dotnet/runtime/blob/master/docs/project/strong-name-signing.md

Based on the above, this seems like a good idea for reasons aside from resolving #700.

@nigel-sampson
Copy link
Contributor

Thanks, what I may do is push a revert to that last commit of mine and then rebase this PR.

@willson556
Copy link
Contributor Author

Fine by me!

@nigel-sampson
Copy link
Contributor

Reverted my commit, feel free to rebase, let's leave the target frameworks alone.

@nigel-sampson nigel-sampson added this to the v4.0.0 milestone Jun 11, 2020
@nigel-sampson
Copy link
Contributor

nigel-sampson commented Jun 11, 2020

Although does having the different frameworks solve you issue? ie. Does just the strong naming problem fix it.

Also, reduced the number of targets required.
@willson556
Copy link
Contributor Author

Just finished testing and it works for me regardless of whether the frameworks change is present. Rebased as requested and removed the TargetFrameworks change in the Caliburn.Micro.Core project.

@nigel-sampson nigel-sampson merged commit b5e278c into Caliburn-Micro:master Jun 11, 2020
@nigel-sampson
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants