Update Xamarin.Forms NavigationPageAdapter #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… activate/deactivate logic when navigating
|
A good change, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small tweak to the Xamarin.Forms NavigationPageAdapter to allow users to apply additional logic when a page is pushed or popped from the navigation stack.
As an example, I have a cross-cutting concern for network connectivity in my application. Users are able to navigate while offline, but I need a visual indicator on each page to show connectivity. Rather than have all pages in the application query the network status on activation, it would be ideal if the network status was provided to them externally as they navigated. With this PR I can subclass NavigationPageAdapter to provide status when pages are pushed/popped.