Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Caliburn.Micro.Core from profile based PCL to .Net Standard based PCL #371

Closed
ItayPodhajcer opened this issue Sep 20, 2016 · 9 comments
Milestone

Comments

@ItayPodhajcer
Copy link

At the moment, when a PCL project is changed from using profiles to using .Net Standard versions, the Caliburn.Micro.Core NuGet package cannot be added to it.
Probably caused by the package not being updated to the new package dependencies model.

@ItayPodhajcer ItayPodhajcer changed the title Transition Caliburn.Micro.Core from profile base PCL to .Net Standard based PCL Transition Caliburn.Micro.Core from profile based PCL to .Net Standard based PCL Sep 20, 2016
@nigel-sampson
Copy link
Contributor

Was hoping to leave this until the teams sorted out the whole project.json fiasco, but it looks like we may not.

@nigel-sampson nigel-sampson added this to the v3.1.0 milestone Sep 21, 2016
@ItayPodhajcer
Copy link
Author

Would be happy to PR this to help make it happen faster.
If the code is already profile based compatible (no #IF directives), then it's only a matter of targeting .Net Standard 1.4 or lower (to support UAP) and adding the relevant Microsoft packages (such as System.ComponentModel).

@nigel-sampson
Copy link
Contributor

Just pushed the work on the dev/4.0.0 branch doing this transition for Caliburn.Micro.Core, still need to do Caliburn.Micro.Platform.Core.

nigel-sampson added a commit that referenced this issue Jun 5, 2017
Temporary while building multitargeting project
nigel-sampson added a commit that referenced this issue Jun 5, 2017
Inital framework targeting .NET 4.5
nigel-sampson added a commit that referenced this issue Jun 5, 2017
Using .NET Standard 1.4 target framework
nigel-sampson added a commit that referenced this issue Jun 5, 2017
nigel-sampson added a commit that referenced this issue Jun 5, 2017
@nigel-sampson
Copy link
Contributor

nigel-sampson commented Jun 6, 2017

We now have Caliburn.Micro.Core and Caliburn.Micro.Platform.Core targeting .NET Standard 1.0 (ensures we can still work 4.5).

Caliburn.Micro.Platform is now a multi-targeted project with the following frameworks netstandard1.4;net45;uap10.0;MonoAndroid10;Xamarin.iOS (where netstandard1.4 will be Xamarin.Forms).

This is definitely the first rough cut. There's some work to be done getting the samples working against these as well as the packaging story.

nigel-sampson added a commit that referenced this issue Jun 17, 2017
nigel-sampson pushed a commit that referenced this issue Oct 26, 2017
nigel-sampson pushed a commit that referenced this issue Oct 26, 2017
nigel-sampson pushed a commit that referenced this issue Oct 26, 2017
@godrose
Copy link

godrose commented Dec 17, 2017

@nigel-sampson Any update on the nuget package release/pre-release date?

@nigel-sampson
Copy link
Contributor

nigel-sampson commented Dec 18, 2017

Not sure, I was loathe to distribute the new assemblies via nuget until we had the functionality changes 4.0.0.

But if people are keen we can do a 4.0.0-alpha with the knowledge that would be heavy breaking changes between that and 4.0.0-beta.

@godrose
Copy link

godrose commented Dec 18, 2017 via email

@joaomatossilva
Copy link

With the latest update to VisualStudio, we can't create PCL based projects with Xamarin.Forms. I think at least an Alpha version should be out there...

@nigel-sampson
Copy link
Contributor

Good to know, I'll up the priority on a very early alpha. but will come with some heavy warnings that there will be breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants