Action binding issue in WPF Popup

[869570967]

I defined a template in ItemsControl, and there is a button in the template that supports popping up a Popup. However, because a Popup is essentially a window with an independent visual tree, it cannot find the action. I searched for a solution and found a corresponding method that I hope will be helpful to you. I have tested it and it indeed works.

https://www.cnblogs.com/gaoshang212/p/4203929.html

[869570967]

I optimized the blog code above. Just comment out currentElement = BindingScope.GetVisualParent(currentElement); and add the code within the red box.

[869570967]

This approach can simultaneously resolve the binding issue of the ContextMenu, because the ContextMenu is also displayed through a Popup.

[vb2ae]

Thanks I will test the change this weekend. @869570967 did you want to create the pr?

[869570967]

Yes, but I previously created a branch and found that I couldn't push the branch to your repository. @vb2ae

[869570967]

Fixed two issues: one is a bug in the current post, and the other is a crash exception that occurs when the ComboBox triggers the SelectionChanged event and binds the SelectedItem property before it has loaded. Please take a look at the branch I switched to and see if you can review and merge it.

https://github.com/508159280/Caliburn.Micro

[869570967]

@vb2ae

[vb2ae]

could you create a pr from your fork into this repo?

[869570967]

I haven't tried it, so I don't know how to handle it. I found a way to create a pull request and have already created one. Could you check if this is what you wanted? @vb2ae

[869570967]

[869570967]

If the PR has no issues, please package it and update it to NuGet after merging. I’ll try it tomorrow, thanks. @vb2ae

[869570967]

@vb2ae Hello, has the PR I submitted been published to NuGet?