Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Greek translation (#377) #378

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

manios
Copy link
Contributor

@manios manios commented Oct 4, 2021

No description provided.

i18n/el.yaml Outdated
@@ -0,0 +1,70 @@
toggleMenu:
other: Toggle Menu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manios Is it possible you overlooked this one? :)
I don't know shit about Greek but perhaps one of these translations could be right:
αλλαγή μενού
εναλλαγή μενού

Copy link
Contributor Author

@manios manios Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @totoroot , @CaiJimmy !

Thanks for the mention. I have added the translation Εναλλαγή μενού in f0870b8, although I am quite sure that is not the 100% correct Greek translation for that.

If you want I can squash the 2 commits into one and push again.

Thanks again for your time!
Christos

@CaiJimmy
Copy link
Owner

Thanks for the PR ⭐

Can you take a look at the review given by @totoroot please?

@CaiJimmy CaiJimmy changed the title feat(i18n): Add Greek translation (#377) feat(i18n): add Greek translation (#377) Oct 22, 2021
@CaiJimmy CaiJimmy added the feature New feature or request label Oct 22, 2021
@CaiJimmy CaiJimmy merged commit ca9dcc8 into CaiJimmy:master Oct 22, 2021
@CaiJimmy
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants