Minor improvements to pagination functions #1165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be failing on Vercel - but I don't have access or a Vercel account, so I guess this is a specific test for you CaiJimmy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pagination looks like this (and bothers me substantially - since it doesn't properly utilize the space):
After this addition, the pagination comprises the full width of the space
Once you get to a middle point in the pages list, it creates ellipsis on both sides:
Pixel 7 Virtualization when using Chrome:
Open to feedback or requests for tweaks.
This was tested by symbolicly linking the layouts' folder in this repo, into the demo repo and copying the blog posts multiple times to bring the pagination up to 5, to 8, and to 11 to test.