Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(giscus): use current language as fallback for lang param and add loading param #1075

Merged
merged 1 commit into from
Oct 19, 2024
Merged

feat(giscus): use current language as fallback for lang param and add loading param #1075

merged 1 commit into from
Oct 19, 2024

Conversation

xiaoxiyao
Copy link
Contributor

see #1062

@xiaoxiyao xiaoxiyao mentioned this pull request Oct 12, 2024
Closed
CaiJimmy
CaiJimmy requested changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@CaiJimmy CaiJimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

layouts/partials/comments/provider/giscus.html Outdated Show resolved Hide resolved
@CaiJimmy CaiJimmy changed the title fix: giscus use current lang as default，and add missing loading params feat(giscus): use current language as fallback for lang param and add loading param Oct 19, 2024
CaiJimmy
CaiJimmy approved these changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@CaiJimmy CaiJimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CaiJimmy CaiJimmy merged commit 8a7fb33 into CaiJimmy:master Oct 19, 2024
4 of 5 checks passed
cyp0633 pushed a commit to cyp0633/stack-mod that referenced this pull request Oct 20, 2024
@xiaoxiyao @cyp0633
feat(giscus): use current language as fallback for lang param and a…
8b6cf91 
…dd `loading` param (CaiJimmy#1075)

fix: giscus use current lang as default, and add missing `loading` params
NapalmCodes added a commit to NapalmCodes/hugo-theme-stack that referenced this pull request Nov 13, 2024
@NapalmCodes @CaiJimmy
@weeix @asimmon @dashjay @ensag-dev @zeridon @saikadaramakaisosjupita @gvoze32 @powerfullz @Cryolitia @onavas33 @xiaoxiyao
Updates (#4)
5d5d301 
* fix: article category overflow (CaiJimmy#1055)

closes CaiJimmy#1045

* fix(i18n): fix unlocalized article publish/lastUpdated date (CaiJimmy#1050)

closes CaiJimmy#1040

* fix: use Hugo's default RSS template value source for lastBuildDate (CaiJimmy#1006)

Use Hugo's default RSS template value source for lastBuildDate

* feat(comments): add support to Gitalk `proxy` parameter (CaiJimmy#1012)

Co-authored-by: Jimmy Cai <hi@jimmycai.com>

* feat(i18n): add Occitan translations (CaiJimmy#1034)

* feat(i18n): add Bulgarian translations (CaiJimmy#1007)

* doc: add backslash to `baseURL` in exampleSite (CaiJimmy#1009)

* chore: bump Twikoo front-end to latest released version `1.6.39` (CaiJimmy#1021)

* fix: use `css.Sass` instead of deprecated `resources.ToCSS` (CaiJimmy#1054)

* doc: add `markup.goldmark.extensions.passthrough` in exampleSite (CaiJimmy#1056)

Related: CaiJimmy#1019

* fix(exampleSite): site config key `paginate` was deprecated (CaiJimmy#1057)

fix: site config key paginate was deprecated

* release: 3.27.0

* fix: show different subtitle for each i18n variant in exampleSite (CaiJimmy#1068)

* fix(colorScheme): systemPreferScheme not initialized on start up (CaiJimmy#1061)

* fix(i18n): missing translation for title of categories widget in fr.yaml (CaiJimmy#1059)

* feat(giscus): use current language as fallback for `lang` param and add `loading` param (CaiJimmy#1075)

fix: giscus use current lang as default, and add missing `loading` params

* feat: add fingerprints to the JS file URL to utilize HTTP caching (CaiJimmy#1076)

* release: 3.28.0

* feat: search box in 404 page (CaiJimmy#1081)

* fix(giscus): fallback to `en` if no language code is set (CaiJimmy#1084)

* release: 3.29.0

---------

Co-authored-by: Jimmy Cai <hi@jimmycai.com>
Co-authored-by: weeix <weeix@users.noreply.github.com>
Co-authored-by: Anthony Simmon <simmon.anthony@gmail.com>
Co-authored-by: DashJay <45532257+dashjay@users.noreply.github.com>
Co-authored-by: ensag-dev <59049879+ensag-dev@users.noreply.github.com>
Co-authored-by: Vladimir Vitkov <5081863+zeridon@users.noreply.github.com>
Co-authored-by: saikadaramakaisosjupita <162842238+saikadaramakaisosjupita@users.noreply.github.com>
Co-authored-by: Syafa Adena <gvoze32@gmail.com>
Co-authored-by: powerfullz <61956140+powerfullz@users.noreply.github.com>
Co-authored-by: PukNgae Cryolitia <Cryolitia@gmail.com>
Co-authored-by: onavas33 <71631187+onavas33@users.noreply.github.com>
Co-authored-by: xiaoxiyao <xiyao.luoxiao@gmail.com>
NapalmCodes added a commit to NapalmCodes/hugo-theme-stack that referenced this pull request Nov 13, 2024
@NapalmCodes @CaiJimmy
@weeix @asimmon @dashjay @ensag-dev @zeridon @saikadaramakaisosjupita @gvoze32 @powerfullz @Cryolitia @onavas33 @xiaoxiyao
Updates (#5)
40df9a3 
* fix: article category overflow (CaiJimmy#1055)

closes CaiJimmy#1045

* fix(i18n): fix unlocalized article publish/lastUpdated date (CaiJimmy#1050)

closes CaiJimmy#1040

* fix: use Hugo's default RSS template value source for lastBuildDate (CaiJimmy#1006)

Use Hugo's default RSS template value source for lastBuildDate

* feat(comments): add support to Gitalk `proxy` parameter (CaiJimmy#1012)

Co-authored-by: Jimmy Cai <hi@jimmycai.com>

* feat(i18n): add Occitan translations (CaiJimmy#1034)

* feat(i18n): add Bulgarian translations (CaiJimmy#1007)

* doc: add backslash to `baseURL` in exampleSite (CaiJimmy#1009)

* chore: bump Twikoo front-end to latest released version `1.6.39` (CaiJimmy#1021)

* fix: use `css.Sass` instead of deprecated `resources.ToCSS` (CaiJimmy#1054)

* doc: add `markup.goldmark.extensions.passthrough` in exampleSite (CaiJimmy#1056)

Related: CaiJimmy#1019

* fix(exampleSite): site config key `paginate` was deprecated (CaiJimmy#1057)

fix: site config key paginate was deprecated

* release: 3.27.0

* fix: show different subtitle for each i18n variant in exampleSite (CaiJimmy#1068)

* fix(colorScheme): systemPreferScheme not initialized on start up (CaiJimmy#1061)

* fix(i18n): missing translation for title of categories widget in fr.yaml (CaiJimmy#1059)

* feat(giscus): use current language as fallback for `lang` param and add `loading` param (CaiJimmy#1075)

fix: giscus use current lang as default, and add missing `loading` params

* feat: add fingerprints to the JS file URL to utilize HTTP caching (CaiJimmy#1076)

* release: 3.28.0

* feat: search box in 404 page (CaiJimmy#1081)

* fix(giscus): fallback to `en` if no language code is set (CaiJimmy#1084)

* release: 3.29.0

---------

Co-authored-by: Jimmy Cai <hi@jimmycai.com>
Co-authored-by: weeix <weeix@users.noreply.github.com>
Co-authored-by: Anthony Simmon <simmon.anthony@gmail.com>
Co-authored-by: DashJay <45532257+dashjay@users.noreply.github.com>
Co-authored-by: ensag-dev <59049879+ensag-dev@users.noreply.github.com>
Co-authored-by: Vladimir Vitkov <5081863+zeridon@users.noreply.github.com>
Co-authored-by: saikadaramakaisosjupita <162842238+saikadaramakaisosjupita@users.noreply.github.com>
Co-authored-by: Syafa Adena <gvoze32@gmail.com>
Co-authored-by: powerfullz <61956140+powerfullz@users.noreply.github.com>
Co-authored-by: PukNgae Cryolitia <Cryolitia@gmail.com>
Co-authored-by: onavas33 <71631187+onavas33@users.noreply.github.com>
Co-authored-by: xiaoxiyao <xiyao.luoxiao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaiJimmy CaiJimmy CaiJimmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxiyao @CaiJimmy