Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks when server doesnt send chunk forget packets #2619

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

MCRcortex
Copy link
Contributor

Fix for #2586 (does not fix or change #2584 as that is a "bug"/behavior difference in vanilla and paper servers and requires a more complex patch)

@IMS212 IMS212 added this to the Sodium 0.5.12 milestone Jul 26, 2024
Copy link
Member

@IMS212 IMS212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be something better... but this will probably do for now.

@IMS212 IMS212 merged commit 1ea095d into CaffeineMC:dev Aug 1, 2024
1 check passed
IMS212 pushed a commit that referenced this pull request Aug 1, 2024
Co-authored-by: mcrcortex <{ID}+{username}@users.noreply.github.com>
IMS212 pushed a commit that referenced this pull request Aug 1, 2024
Co-authored-by: mcrcortex <{ID}+{username}@users.noreply.github.com>
IMS212 pushed a commit to IMS212/sodium-fabric that referenced this pull request Aug 6, 2024
Co-authored-by: mcrcortex <{ID}+{username}@users.noreply.github.com>
@douira
Copy link
Collaborator

douira commented Aug 13, 2024

Can the referenced issue #2586 be closed since this is merged?

@djmrFunnyMan
Copy link

djmrFunnyMan commented Aug 13, 2024

Jelly said no
Screenshot_20240813_132705_Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants