new: optimize VoxelShapes.matchesAnywhere using simplicity of cuboid shapes #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2No2Name
force-pushed
the
1.16.x/pull/fast_matchesAnywhere
branch
from
443cc15
to
886d27d
Compare
|
Profiling showed about 50% lower runtime in a test setup that contains both collisions between two cuboids, and between cuboids and more complex shapes. (Setup: took the Test class and only ran the vanilla, and then only ran the modded code (with vanilla fallback), result: runtime is 50% lower when running modded code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids the allocations in VoxelShapes.matchesAnywhere (PairLists and lambdas) in cases where it is called with at least one cuboid shape as argument. If both arguments are cuboid shapes the collision calculation is very simple.
The correctness was tested by randomly trying out millions of collisions.
Performance testing still needs to be done