feat: complete AnyIO migration #23

CaddyGlow · 2025-10-05T23:07:39Z

Summary

migrate the runtime facade and task manager to AnyIO primitives, removing direct asyncio dependencies across core services
refactor hook execution, streaming responses, DuckDB access-log ingestion, and permissions flows to operate on the shared async runtime
tighten regression coverage with unit/integration stress suites that exercise high-concurrency hooks, task cancellation cycles, DuckDB ingest/pagination, streaming responses, and permissions SSE handling
update documentation and helper utilities so downstream services consistently consume the new runtime helpers

Testing

uv run ruff check
uv run mypy
uv run pytest
uv run pytest tests/api/middleware/test_streaming_stress.py -m slow
uv run pytest tests/plugins/permissions/integration/test_permissions_sse_stress.py -m slow
uv run pytest tests/plugins/analytics/integration/test_duckdb_access_log_stress.py tests/plugins/analytics/integration/test_analytics_pagination_stress.py -m slow
uv run pytest tests/unit/core/test_async_task_manager.py -m slow
uv run pytest tests/unit/core/test_background_hook_thread_manager.py -m slow

* Reduce log verbosity to ERROR level in test fixtures * Upgrade claude_api and codex client fixtures to module scope * Remove redundant auth_missing integration tests (covered by unit tests) * Mock asyncio.sleep in copilot OAuth polling tests * Reduce timeout intervals in permission and scheduler tests

- Update README and installation guide to reference stable v0.2.0 release instead of dev branch - Add OAuth plugin architecture documentation (OAUTH_PLUGIN_ARCHITECTURE.md) - Add v0.2 plugin-first migration guide (0.2-plugin-first.md) - Add v0.2.0 release status documentation (release-v0.2-status.md) - Remove dummy plugin dependency from pyproject.toml - Update dependency versions: duckdb, pyyaml, ruff, uvicorn, starlette, rpds-py, and others

Copilot

Pull Request Overview

This PR removes large portions of legacy code and simplifies the architecture by consolidating authentication, OAuth, storage, and API functionality. The changes focus on unifying authentication patterns across providers and establishing a cleaner plugin-based architecture.

Key changes:

Consolidates OAuth authentication into a unified registry-based system with standardized providers
Simplifies storage layer by creating generic implementations that work across all credential types
Removes provider-specific implementations in favor of generic, reusable components
Streamlines API routes by removing complex proxy endpoints and metrics dashboards

Reviewed Changes

Copilot reviewed 79 out of 785 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ccproxy/claude_sdk/options.py	Completely removed - functionality moved to plugin system
ccproxy/auth/storage/generic.py	New generic storage using Pydantic validation for all credential types
ccproxy/auth/oauth/registry.py	New OAuth provider registry for dynamic provider management
ccproxy/auth/oauth/templates.py	Centralized HTML templates for OAuth responses
ccproxy/auth/oauth/flows.py	OAuth flow engines for CLI authentication
ccproxy/auth/managers/base.py	New base token manager for all authentication providers
ccproxy/api/routes/plugins.py	New plugin management API endpoints

Comments suppressed due to low confidence (1)

ccproxy/auth/oauth/base.py:1

The comment mentions non-standard implementations but the code doesn't actually include the state parameter in the base implementation. The comment should clarify that subclasses need to override this method to include state when needed, or provide a mechanism for including it conditionally.

"""Base OAuth client with common PKCE flow implementation."""

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-05T23:08:45Z

ccproxy/auth/oauth/flows.py

+        console.print("[dim]Scan QR code with mobile device[/dim]")
+    except ImportError:
+        # QR code library not available - graceful degradation
+        pass


The ImportError exception is caught but provides no feedback to the user that QR code generation failed. Consider logging this condition or providing a fallback message to indicate QR codes are unavailable.

Suggested change

pass

logger.warning("qrcode_library_missing", url=url)

console.print("[yellow]QR code generation unavailable: missing 'qrcode' library.[/yellow]")

Copilot · 2025-10-05T23:08:45Z

ccproxy/auth/oauth/flows.py

+                    raise PortBindError(
+                        f"Failed to start callback server on port {self.port}"
+                    ) from e
+                elif e.errno == 48:  # Address already in use


The code assumes e.errno exists for all OSError instances, but SystemExit doesn't have an errno attribute. This will cause an AttributeError when a SystemExit is converted to PortBindError and then the elif condition is checked.

Suggested change

elif e.errno == 48: # Address already in use

elif isinstance(e, OSError) and getattr(e, "errno", None) == 48: # Address already in use

Copilot · 2025-10-05T23:08:46Z

ccproxy/auth/managers/base.py

+            expires_at = expires_at.replace(tzinfo=UTC)
+
+        delta = expires_at - datetime.now(UTC)


The method modifies the expires_at datetime object in place when adding timezone info. Consider creating a new datetime object instead of modifying the original to avoid side effects: expires_at = expires_at.replace(tzinfo=UTC)

Suggested change

expires_at = expires_at.replace(tzinfo=UTC)

delta = expires_at - datetime.now(UTC)

expires_at_utc = expires_at.replace(tzinfo=UTC)

else:

expires_at_utc = expires_at

delta = expires_at_utc - datetime.now(UTC)

Copilot

Pull Request Overview

Copilot reviewed 81 out of 83 changed files in this pull request and generated 6 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T04:16:05Z

ccproxy/core/async_runtime.py

+    def run(self, awaitable: Awaitable[_T]) -> _T:
+        """Run an awaitable to completion using the active runtime."""
+        if not asyncio.iscoroutine(awaitable):
+            raise TypeError("runtime.run() expects a coroutine object")
+
+        async def _runner() -> _T:
+            return cast(_T, await awaitable)
+
+        return anyio.run(_runner)


The type check on line 138 is too restrictive. It only accepts coroutines but the function signature accepts any Awaitable[_T], which includes futures and other awaitable objects. This will cause runtime errors when passing valid awaitables that aren't coroutines.

Copilot · 2025-10-06T04:16:05Z

tests/unit/services/mocking/test_mock_handler.py

+    monkeypatch.setattr(
+        "ccproxy.services.mocking.mock_handler.runtime_sleep", fast_sleep
+    )


The patching path has changed from asyncio.sleep to ccproxy.services.mocking.mock_handler.runtime_sleep. Ensure this matches the actual import path in the module being tested to avoid the patch not taking effect.

Copilot · 2025-10-06T04:16:05Z

tests/plugins/permissions/integration/test_permissions_sse_stress.py

+async def test_sse_confirmation_handler_stress(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    manager = AsyncTaskManager(max_tasks=512, shutdown_timeout=5.0)


[nitpick] The stress test creates an AsyncTaskManager with 512 max tasks but only processes 80 requests. Consider reducing max_tasks to a more appropriate value like 128 to avoid over-allocation in test environments.

Suggested change

manager = AsyncTaskManager(max_tasks=512, shutdown_timeout=5.0)

manager = AsyncTaskManager(max_tasks=128, shutdown_timeout=5.0)

Copilot · 2025-10-06T04:16:06Z

ccproxy/services/cli_detection.py

+            process = await runtime_create_subprocess_exec(
                *cmd,
-                stdout=asyncio.subprocess.PIPE,
-                stderr=asyncio.subprocess.PIPE,
+                stdout=PIPE,
+                stderr=PIPE,
            )


[nitpick] The function uses runtime_create_subprocess_exec but still imports PIPE from the runtime module. Consider using a more descriptive constant or ensuring consistency in how subprocess constants are accessed.

Copilot · 2025-10-06T04:16:06Z

ccproxy/plugins/docker/adapter.py

+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,


The code imports runtime_create_subprocess_exec but uses subprocess.PIPE instead of the runtime's PIPE constant. This creates an inconsistency and should use PIPE from the async_runtime module for consistency.

Copilot · 2025-10-06T04:16:06Z

ccproxy/plugins/duckdb_storage/storage.py

+            if str(self.database_path) == ":memory:":
+                return self._store_request_sync(payload)


[nitpick] The special case for :memory: databases runs synchronously on the event loop. This could block the loop for I/O operations. Consider whether memory databases also benefit from thread execution or if this optimization is necessary.

Suggested change

if str(self.database_path) == ":memory:":

return self._store_request_sync(payload)

CaddyGlow added 23 commits October 4, 2025 12:59

refactor(cli): remove unused claude command and simplify serve module

ed90b01

feat(async): introduce runtime facade for asyncio-to-anyio migration

e1a53ee

refactor(scheduler): route task loop through async runtime

5474fff

refactor(core): use runtime primitives in request context and hooks

95a2862

refactor(credential-balancer): align locks with runtime facade

6316fb7

refactor(cli): rely on async runtime for detection helpers

0f894ee

refactor(services): use runtime helpers in HTTP pool and mock handler

e8a7198

refactor(claude-sdk): use runtime CancelledError

fe0f004

refactor(runtime): route auth and docker through runtime facade

3570fca

refactor(scheduler): use runtime primitives for concurrency

67727d6

refactor(detection): use runtime helpers for CLI subprocesses

6aa520a

refactor(permissions): route CLI handlers through runtime

5568170

refactor: migrate remaining asyncio usage to runtime facade

f76e01b

feat: switch async runtime to anyio

3a992c7

chore: document async runtime usage

f505af0

feat(core): surface anyio primitives

c780fef

refactor(core): simplify async task manager

203a024

refactor(hooks): replace thread executor with async tasks

345c2ca

refactor(hooks): route background manager through runtime

b3e1a46

refactor(core): remove direct asyncio dependency from task manager

7b46453

test: add slow stress suites for hooks, tasks, and analytics

5028e7c

Copilot AI review requested due to automatic review settings October 5, 2025 23:07

Copilot AI reviewed Oct 5, 2025

View reviewed changes

CaddyGlow changed the title ~~test: add slow stress suites for hooks, tasks, and analytics~~ feat: complete AnyIO migration Oct 5, 2025

CaddyGlow changed the base branch from main to dev/v0.2 October 6, 2025 04:09

CaddyGlow requested a review from Copilot October 6, 2025 04:14

Repository owner deleted a comment from Copilot AI Oct 6, 2025

Copilot AI reviewed Oct 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: complete AnyIO migration #23

feat: complete AnyIO migration #23

Uh oh!

CaddyGlow commented Oct 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 5, 2025

Uh oh!

Copilot AI Oct 5, 2025

Uh oh!

Copilot AI Oct 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	pass
	logger.warning("qrcode_library_missing", url=url)
	console.print("[yellow]QR code generation unavailable: missing 'qrcode' library.[/yellow]")

	elif e.errno == 48: # Address already in use
	elif isinstance(e, OSError) and getattr(e, "errno", None) == 48: # Address already in use

		expires_at = expires_at.replace(tzinfo=UTC)

		delta = expires_at - datetime.now(UTC)

-            expires_at = expires_at.replace(tzinfo=UTC)
-        delta = expires_at - datetime.now(UTC)
+            expires_at_utc = expires_at.replace(tzinfo=UTC)
+        else:
+            expires_at_utc = expires_at
+        delta = expires_at_utc - datetime.now(UTC)

	manager = AsyncTaskManager(max_tasks=512, shutdown_timeout=5.0)
	manager = AsyncTaskManager(max_tasks=128, shutdown_timeout=5.0)

		if str(self.database_path) == ":memory:":
		return self._store_request_sync(payload)

feat: complete AnyIO migration #23

Are you sure you want to change the base?

feat: complete AnyIO migration #23

Uh oh!

Conversation

CaddyGlow commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

CaddyGlow commented Oct 5, 2025 •

edited

Loading