Skip to content

Fix rect - #939

Merged
marcus7070 merged 1 commit into
masterfrom
rect-fix
Dec 28, 2021
Merged

Fix rect#939
marcus7070 merged 1 commit into
masterfrom
rect-fix

Conversation

@adam-urbanczyk

Copy link
Copy Markdown
Member

w,h were reversed

Fixes #938

w,h were reversed
@codecov

codecov Bot commented Dec 27, 2021

Copy link
Copy Markdown

Codecov Report

Merging #939 (48b82ee) into master (9ceea9c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 48b82ee differs from pull request most recent head 9201c40. Consider uploading reports for the commit 9201c40 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          39       39           
  Lines        9204     9204           
  Branches     1109     1109           
=======================================
  Hits         8842     8842           
  Misses        209      209           
  Partials      153      153           
Impacted Files Coverage Δ
cadquery/sketch.py 96.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ceea9c...9201c40. Read the comment docs.

@jmwright jmwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @adam-urbanczyk

@marcus7070
marcus7070 merged commit 8c5c6d1 into master Dec 28, 2021
@marcus7070

Copy link
Copy Markdown
Member

Thanks @adam-urbanczyk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sketch().rect() height and width reversed

3 participants