Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit doc referring to old centerOption behaviour #847

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Edit doc referring to old centerOption behaviour #847

merged 2 commits into from
Aug 19, 2021

Conversation

Jojain
Copy link
Contributor

@Jojain Jojain commented Aug 15, 2021

This part of the doc was referring to the centerOption being the centerOfMass of a face by default. I changed it to refer to the new behaviour

This part of the doc was referring to the centerOption being the centerOfMass of a face by default. I changed it to refer to the new behaviour
@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #847 (c76c9ff) into master (8dc4972) will not change coverage.
The diff coverage is n/a.

❗ Current head c76c9ff differs from pull request most recent head 3290772. Consider uploading reports for the commit 3290772 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          32       32           
  Lines        7594     7594           
  Branches      806      806           
=======================================
  Hits         7282     7282           
  Misses        184      184           
  Partials      128      128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbadad...3290772. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jojain

@marcus7070
Copy link
Member

The failed tests are network errors, RTD succeeded and that's all that's relevant so I'm merging.

Thanks @Jojain!

@marcus7070 marcus7070 merged commit 247f0e6 into CadQuery:master Aug 19, 2021
@Jojain Jojain deleted the patch-1 branch August 19, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants