Implemented cq.Vector.projectToLine() method - #835
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 32 32
Lines 7654 7663 +9
Branches 815 815
=======================================
+ Hits 7339 7348 +9
Misses 186 186
Partials 129 129
Continue to review full report at Codecov.
|
Contributor
Author
|
'*' operator for cq.Vector should now allow being used for scaledVector = 4 * cq.Vector(1, 1, 1)in addition to the already working scaledVector = cq.Vector(1, 1, 1) * 4 |
adam-urbanczyk
self-requested a review
July 29, 2021 06:39
adam-urbanczyk
approved these changes
Sep 8, 2021
jmwright
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an implementation for the said method, as well as a unit test.