Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented cq.Vector.projectToLine() method #835

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Conversation

A-G-D
Copy link
Contributor

@A-G-D A-G-D commented Jul 25, 2021

Added an implementation for the said method, as well as a unit test.

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #835 (fcb8d30) into master (94030ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fcb8d30 differs from pull request most recent head 1508f15. Consider uploading reports for the commit 1508f15 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          32       32           
  Lines        7654     7663    +9     
  Branches      815      815           
=======================================
+ Hits         7339     7348    +9     
  Misses        186      186           
  Partials      129      129           
Impacted Files Coverage Δ
cadquery/occ_impl/geom.py 99.57% <100.00%> (+<0.01%) ⬆️
tests/test_cad_objects.py 99.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94030ad...1508f15. Read the comment docs.

@A-G-D
Copy link
Contributor Author

A-G-D commented Jul 26, 2021

'*' operator for cq.Vector should now allow being used for

scaledVector = 4 * cq.Vector(1, 1, 1)

in addition to the already working

scaledVector = cq.Vector(1, 1, 1) * 4

@adam-urbanczyk adam-urbanczyk self-requested a review July 29, 2021 06:39
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @A-G-D

@jmwright jmwright merged commit ba1dfe4 into CadQuery:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants