-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembly toCompound #726
Assembly toCompound #726
Conversation
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 94.60% 94.55% -0.06%
==========================================
Files 32 32
Lines 7215 7249 +34
Branches 785 789 +4
==========================================
+ Hits 6826 6854 +28
- Misses 254 260 +6
Partials 135 135
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixed, @jmwright. Shall I merge? |
+1 |
Thanks @marcus7070 ! |
Will resolve #724 (since you can now do
assy.toCompound().BoundingBox()
), and I think it's the best way to resolve #629.