Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly toCompound #726

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Assembly toCompound #726

merged 4 commits into from
Apr 19, 2021

Conversation

marcus7070
Copy link
Member

@marcus7070 marcus7070 commented Apr 15, 2021

Will resolve #724 (since you can now do assy.toCompound().BoundingBox()), and I think it's the best way to resolve #629.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #726 (7d71ab9) into master (b0a8cb2) will decrease coverage by 0.05%.
The diff coverage is 91.89%.

❗ Current head 7d71ab9 differs from pull request most recent head 6a7b31b. Consider uploading reports for the commit 6a7b31b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   94.60%   94.55%   -0.06%     
==========================================
  Files          32       32              
  Lines        7215     7249      +34     
  Branches      785      789       +4     
==========================================
+ Hits         6826     6854      +28     
- Misses        254      260       +6     
  Partials      135      135              
Impacted Files Coverage Δ
cadquery/occ_impl/geom.py 88.50% <0.00%> (-0.58%) ⬇️
cadquery/assembly.py 91.70% <100.00%> (+0.62%) ⬆️
cadquery/occ_impl/shapes.py 92.37% <100.00%> (ø)
tests/test_assembly.py 100.00% <100.00%> (ø)
cadquery/cqgi.py 78.92% <0.00%> (-2.48%) ⬇️
tests/test_workplanes.py 99.30% <0.00%> (-0.70%) ⬇️
cadquery/occ_impl/solver.py 92.91% <0.00%> (+2.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a8cb2...6a7b31b. Read the comment docs.

@marcus7070 marcus7070 marked this pull request as ready for review April 15, 2021 21:40
tests/test_assembly.py Outdated Show resolved Hide resolved
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

marcus7070 and others added 2 commits April 17, 2021 13:36
Co-authored-by: Jeremy Wright <wrightjmf@gmail.com>
@jmwright
Copy link
Member

Looks like there's a mypy error.

Screenshot from 2021-04-19 06-07-24

@adam-urbanczyk
Copy link
Member

Fixed, @jmwright. Shall I merge?

@jmwright
Copy link
Member

+1

@adam-urbanczyk adam-urbanczyk merged commit 0f249df into master Apr 19, 2021
@adam-urbanczyk
Copy link
Member

Thanks @marcus7070 !

@marcus7070 marcus7070 deleted the marcus7070/assembly-toCompound branch November 13, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounding box for an assembly There is no function to create a solid from assembly
3 participants