Skip to content

tangentAt fix - #641

Merged
adam-urbanczyk merged 4 commits into
masterfrom
tangentAt-fix
Feb 15, 2021
Merged

tangentAt fix#641
adam-urbanczyk merged 4 commits into
masterfrom
tangentAt-fix

Conversation

@adam-urbanczyk

Copy link
Copy Markdown
Member

Will resolve #640

@codecov

codecov Bot commented Feb 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #641 (ed41810) into master (d1ebfba) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   93.94%   93.98%   +0.03%     
==========================================
  Files          31       31              
  Lines        6543     6546       +3     
  Branches      713      713              
==========================================
+ Hits         6147     6152       +5     
+ Misses        258      257       -1     
+ Partials      138      137       -1     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 91.92% <100.00%> (ø)
tests/test_cadquery.py 99.09% <100.00%> (+<0.01%) ⬆️
cadquery/cq.py 89.86% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ebfba...ed41810. Read the comment docs.

@jmwright jmwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good @adam-urbanczyk

Shall I merge?

@adam-urbanczyk
adam-urbanczyk merged commit 0dcccc3 into master Feb 15, 2021
@adam-urbanczyk

Copy link
Copy Markdown
Member Author

Done

@jmwright
jmwright deleted the tangentAt-fix branch October 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge.tangentAt() is Broken

2 participants