-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offset2D for construction #639
offset2D for construction #639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 94.02% 94.03%
=======================================
Files 31 31
Lines 6627 6636 +9
Branches 724 726 +2
=======================================
+ Hits 6231 6240 +9
Misses 258 258
Partials 138 138
Continue to review full report at Codecov.
|
Ready for review now. |
@marcus7070 Thanks for putting this together. Feel free to request a review or just let us know when this is ready. I see the checks are still running right now. |
Whoops, we hit Comment at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcus7070 I think it looks good, thanks!
We can merge after @adam-urbanczyk has had a chance to review and comment.
@marcus7070 I think once the conflicts are resolved we can merge. |
Thanks @marcus7070 ! |
Will close #618.
I added a new example that covers offset2D as well.