Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offset2D for construction #639

Merged
merged 4 commits into from
Feb 19, 2021

Conversation

marcus7070
Copy link
Member

Will close #618.

I added a new example that covers offset2D as well.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #639 (71fd991) into master (3505fc2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   94.02%   94.03%           
=======================================
  Files          31       31           
  Lines        6627     6636    +9     
  Branches      724      726    +2     
=======================================
+ Hits         6231     6240    +9     
  Misses        258      258           
  Partials      138      138           
Impacted Files Coverage Δ
cadquery/cq.py 89.89% <100.00%> (+0.04%) ⬆️
tests/test_cadquery.py 99.13% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3505fc2...71fd991. Read the comment docs.

@marcus7070
Copy link
Member Author

Ready for review now.

@jmwright
Copy link
Member

@marcus7070 Thanks for putting this together. Feel free to request a review or just let us know when this is ready. I see the checks are still running right now.

@jmwright
Copy link
Member

Whoops, we hit Comment at the same time.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcus7070 I think it looks good, thanks!

We can merge after @adam-urbanczyk has had a chance to review and comment.

@jmwright
Copy link
Member

@marcus7070 I think once the conflicts are resolved we can merge.

@marcus7070 marcus7070 merged commit 606eb27 into CadQuery:master Feb 19, 2021
@marcus7070 marcus7070 deleted the offset2d-forConstruction2 branch February 19, 2021 00:19
@jmwright
Copy link
Member

Thanks @marcus7070 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forConstruction option in offset2d
3 participants