Skip to content

fix .rect calls in tests#607

Merged
jmwright merged 1 commit intoCadQuery:masterfrom
marcus7070:fix-rect-in-tests
Jan 30, 2021
Merged

fix .rect calls in tests#607
jmwright merged 1 commit intoCadQuery:masterfrom
marcus7070:fix-rect-in-tests

Conversation

@marcus7070
Copy link
Copy Markdown
Member

Just noticed these two lines looked wrong.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2021

Codecov Report

Merging #607 (490f272) into master (36d4178) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          29       29           
  Lines        6366     6366           
  Branches      679      679           
=======================================
  Hits         6000     6000           
  Misses        227      227           
  Partials      139      139           
Impacted Files Coverage Δ
tests/test_cadquery.py 99.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d4178...490f272. Read the comment docs.

Copy link
Copy Markdown
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcus7070 Thanks for fixing this. @adam-urbanczyk Are you ok with merging this?

@adam-urbanczyk
Copy link
Copy Markdown
Member

+1

@jmwright jmwright merged commit 68bac66 into CadQuery:master Jan 30, 2021
@marcus7070 marcus7070 deleted the fix-rect-in-tests branch January 30, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants