Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ex025 for sweeping a wire along a helix from cq.Wire.makeHelix() #594

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

daemacles
Copy link

This adds an example for essentially extruding a 2D wire shape along a helix.

@jmwright
Copy link
Member

@daemacles Thanks for writing this up. It looks like the lint check is failing. Can you take a look at that?

1 similar comment
@jmwright
Copy link
Member

@daemacles Thanks for writing this up. It looks like the lint check is failing. Can you take a look at that?

@daemacles
Copy link
Author

daemacles commented Jan 19, 2021 via email

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #594 (e483b04) into master (4c77c87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files          29       29           
  Lines        6348     6348           
  Branches      675      675           
=======================================
  Hits         5984     5984           
  Misses        226      226           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c77c87...e483b04. Read the comment docs.

@jmwright
Copy link
Member

Thanks @daemacles !

@jmwright jmwright merged commit 53a76d4 into CadQuery:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants