Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.workplane docstring update #563

Merged
merged 2 commits into from
Jan 5, 2021
Merged

.workplane docstring update #563

merged 2 commits into from
Jan 5, 2021

Conversation

adam-urbanczyk
Copy link
Member

No description provided.

@adam-trhon
Copy link
Contributor

adam-trhon commented Jan 5, 2021

@adam-urbanczyk hello, please also check the quick start manual, section "More Holes", line 10, point 2 (it says that "The center point of a workplane on a face is always at the center of the face, which works well here")

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #563 (aa72778) into master (7650436) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #563   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files          29       29           
  Lines        6220     6220           
  Branches      665      665           
=======================================
  Hits         5859     5859           
  Misses        224      224           
  Partials      137      137           
Impacted Files Coverage Δ
cadquery/cq.py 89.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7650436...aa72778. Read the comment docs.

@marcus7070
Copy link
Member

Looks good to me!

@jmwright
Copy link
Member

jmwright commented Jan 5, 2021

I'm re-running two CI checks that seem to have failed for no reason.

@jmwright
Copy link
Member

jmwright commented Jan 5, 2021

Last two CI checks pass now after being run again.

Has the comment from @adam-trhon been addressed? I'm not sure what the intent of that comment was.

@adam-trhon
Copy link
Contributor

adam-trhon commented Jan 5, 2021

@jmwright If I understand the quoted sentence right, it refers to the previous defualt (which was CenterOfMass), not the current default. Namely the "center point of a workplane on a face is always at the center of the face" part. It think it should be changed to something as "center point of a workplane on a face is at the center of the face in this case".

@adam-urbanczyk
Copy link
Member Author

@adam-trhon @jmwright I removed the confusing line completely. Do you think that the tutorial remains clear?

@jmwright
Copy link
Member

jmwright commented Jan 5, 2021

+1

@adam-urbanczyk
Copy link
Member Author

Alright, merging.

@adam-urbanczyk adam-urbanczyk merged commit 2152068 into master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants