Merged
Conversation
Member
Author
|
CC: @bernhard-42 |
Closed
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 94.15% 94.30% +0.14%
==========================================
Files 29 29
Lines 6189 6334 +145
Branches 655 670 +15
==========================================
+ Hits 5827 5973 +146
Misses 224 224
+ Partials 138 137 -1
Continue to review full report at Codecov.
|
jmwright
approved these changes
Dec 16, 2020
Member
|
Looks ok to me. Thanks. |
Member
Author
|
@bernhard-42 do you agree with merging this for now? Based on the discussion in #543 you have some design choices to be made that might take some time. |
Contributor
|
@adam-urbanczyk fine for me. I do have a plan forward. Thanks for adding the hierarchies and the |
Member
Author
|
OK, I'll merge tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves nested assembly naming and enforces unique names on a single assembly level.