Change to ProjectedOrigin

[adam-urbanczyk]

Resolves #314

[adam-urbanczyk]

It should pass now. In principle after merging this we could release (see: https://github.com/CadQuery/cadquery/projects/4), but maybe we want to merge other open PRs too.

[codecov]

Codecov Report

Merging #532 (607f5d7) into master (cf275b0) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   93.94%   94.09%   +0.14%     
==========================================
  Files          30       29       -1     
  Lines        6115     7160    +1045     
  Branches      640      904     +264     
==========================================
+ Hits         5745     6737     +992     
- Misses        235      257      +22     
- Partials      135      166      +31     

Impacted Files	Coverage Δ
cadquery/cq.py	90.39% <ø> (+1.46%)	⬆️
tests/__init__.py	88.23% <100.00%> (+0.73%)	⬆️
tests/test_cadquery.py	99.04% <100.00%> (ø)
tests/test_selectors.py	100.00% <100.00%> (ø)
tests/test_workplanes.py	99.30% <0.00%> (-0.70%)	⬇️
cadquery/utils.py
cadquery/occ_impl/shapes.py	93.18% <0.00%> (+1.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf275b0...607f5d7. Read the comment docs.

[adam-urbanczyk]

Still need to fix some examples it seems.

[jmwright]

@adam-urbanczyk These changes look ok, but I can take another look once the doc tests are passing if you want.

[adam-urbanczyk]

Ok ready with all fixes.

[jmwright]

@adam-urbanczyk I made a few comments. The PR looks good. Thanks for fixing the selector descriptions too.

[adam-urbanczyk]

OK, I'm going ahead with the merge.

[bernhard-42]

@adam-urbanczyk Could it be that this breaks the assembly tutorial? It seems to work again when one e.g. adds centerOption to the second workplane call in make_connector:

def make_connector():

    rv = (
        cq.Workplane()
        .box(20, 20, 20)
        .faces("<X")
        .workplane()
        .cboreHole(6, 15, 18)
        .faces("<Z")
        .workplane(centerOption="CenterOfMass")
        .cboreHole(6, 15, 18)
    )

    # tag mating faces
    rv.faces(">X").tag("X").end()
    rv.faces(">Z").tag("Z").end()

    return rv

[adam-urbanczyk]

Yest it does, thanks @bernhard-42 !