Conversation
|
Thanks for working on this @marcus7070 @adam-urbanczyk The errors with Travis, Appveyor and the doc builds seem to be related to font/text capability. Items like this: Did something change with the deployed versions of OCP? Maybe related to the 7.5 beta? |
|
Indeed @jmwright , should be fine now. |
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 93.74% 93.81% +0.07%
==========================================
Files 30 30
Lines 5994 6067 +73
Branches 636 637 +1
==========================================
+ Hits 5619 5692 +73
Misses 237 237
Partials 138 138
Continue to review full report at Codecov.
|
|
All green now. @marcus7070 I'm assuming this is ready for review now? |
|
Yes, ready for review @jmwright. |
692888d to
41b0e83
Compare
|
So I think when you request the radius of a Wire with multiple Edges, OCCT just takes the radius of the first Edge and calls it a day. You can see code regarding this in It wouldn't be too hard to do some more logic in the |
41b0e83 to
255b464
Compare
|
@jmwright are OK with merging this PR? |
|
Thanks @marcus7070 ! This is a great addition to the selectors. |
Will close #501.
I've added an
Edge.radiusmethod to get the radius of a circular edge.The method uses
_geomAdaptor().Circle(). When I used that code on a elipse, I got the kernel (7.4.0) to segfault. So I've restricted the method to just objects withgeomType() == "CIRCLE"to be safe.I've added a RadiusSelector in the style of DirectionNthSelector.
I didn't add RadiusSelector to the string selector interface.
While I added it to the HTML docs, about half the selectors are not in the top level module and they don't show up due to #493.