Skip to content

VRML export - #482

Merged
jmwright merged 8 commits into
masterfrom
vrml-export
Nov 19, 2020
Merged

VRML export#482
jmwright merged 8 commits into
masterfrom
vrml-export

Conversation

@adam-urbanczyk

Copy link
Copy Markdown
Member

Will resolve #476

@adam-urbanczyk adam-urbanczyk mentioned this pull request Oct 14, 2020
@codecov

codecov Bot commented Oct 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #482 (17ad179) into master (3a50edd) will increase coverage by 0.75%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   93.64%   94.39%   +0.75%     
==========================================
  Files          30       30              
  Lines        5869     7906    +2037     
  Branches      625      972     +347     
==========================================
+ Hits         5496     7463    +1967     
- Misses        234      279      +45     
- Partials      139      164      +25     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.48% <60.00%> (+1.54%) ⬆️
cadquery/occ_impl/exporters/__init__.py 93.06% <100.00%> (+0.36%) ⬆️
tests/test_exporters.py 100.00% <100.00%> (ø)
tests/test_cadquery.py 99.43% <0.00%> (+0.43%) ⬆️
cadquery/occ_impl/geom.py 89.50% <0.00%> (+0.56%) ⬆️
cadquery/cq.py 90.78% <0.00%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a50edd...17ad179. Read the comment docs.

@adam-urbanczyk

Copy link
Copy Markdown
Member Author

Given the feedback in #476 I think it is ready for merging @jmwright .

@jmwright jmwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @adam-urbanczyk thanks! I'll merge here in a second.

@jmwright
jmwright merged commit ec9cd46 into master Nov 19, 2020
@jmwright
jmwright deleted the vrml-export branch October 28, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VRML Export

2 participants