rarray: bound spacings to greater than 0 - #454
Merged
Merged
Conversation
This addresses Issue 451
* Fix a typo. * Pin black version in travis Co-authored-by: Adam Urbańczyk <adam-urbanczyk@users.noreply.github.com>
Member
|
Thanks @JosiahBradley , could you rebase to get the latest Travis conf? |
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 93.61% 93.66% +0.04%
==========================================
Files 25 25
Lines 5326 5334 +8
Branches 554 554
==========================================
+ Hits 4986 4996 +10
+ Misses 215 214 -1
+ Partials 125 124 -1
Continue to review full report at Codecov.
|
Member
|
Thanks for the fix @JosiahBradley , I just added a simple test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses Issue #451 Instead of matching the conditional for the counts I left them alone as the data types are different.