DXF export (2D) and exporters cleanup - #415
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 93.56% 93.59% +0.02%
==========================================
Files 19 25 +6
Lines 5147 5291 +144
Branches 530 548 +18
==========================================
+ Hits 4816 4952 +136
- Misses 209 215 +6
- Partials 122 124 +2
Continue to review full report at Codecov.
|
jmwright
approved these changes
Jul 29, 2020
jmwright
left a comment
Member
There was a problem hiding this comment.
There's a lot here so I could have missed some things, but I think it looks good. It's nice to have the exporters broken out and organized rather than all dumped in one (or very few) files. Thanks!
This was referenced Aug 2, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #352 , #340, #212, #334 and #360 .
This adds dxf export. Moreover I implemented a new export function and marked exportShape as deprecated:
Now exporting is more user friendly:
exporters.export(obj,'out.step')