-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxf splines and ellipse import support #406
Conversation
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 93.56% 93.55% -0.01%
==========================================
Files 19 19
Lines 5083 5139 +56
Branches 523 530 +7
==========================================
+ Hits 4756 4808 +52
- Misses 205 209 +4
Partials 122 122
Continue to review full report at Codecov.
|
@adam-urbanczyk I don't have any at hand, no. |
I think it is ready. NB: I generated rational spline in ezdxf and imported it for the lack of a better test method. It seems to be working fine, random drawings exported from Inkscape import fine. Not all operations work well for all geometries though (filleting is picky) but I was always able to extrude the solid. Still an experimental feature but I think it is as good as it gets for now. |
Looks good as far as I can tell, thanks! |
Will resolve #373