Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polarArray with object rotation #395

Merged
merged 4 commits into from
Jul 9, 2020
Merged

polarArray with object rotation #395

merged 4 commits into from
Jul 9, 2020

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Jul 9, 2020

This will resolve #118

obraz

import cadquery as cq 
b = cq.Workplane().box(10,10,1).faces('>Z').workplane()

e = b.polarArray(3.2,0,360,8,rotate=False).slot2D(3,1,90).cutThruAll()
show_object(e)

e = b.polarArray(3.2,0,360,8,rotate=True).slot2D(3,1,90).cutThruAll()
show_object(e.translate((12,0,0)))

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #395 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   93.44%   93.46%   +0.01%     
==========================================
  Files          19       19              
  Lines        4989     5004      +15     
  Branches      509      514       +5     
==========================================
+ Hits         4662     4677      +15     
  Misses        205      205              
  Partials      122      122              
Impacted Files Coverage Δ
cadquery/cq.py 87.78% <100.00%> (+0.08%) ⬆️
tests/test_cadquery.py 98.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b65388...cf791f5. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title polarArray with object rotation [WIP] polarArray with object rotation Jul 9, 2020
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk As long as the two things I marked were intentional changes, I think this is ready to merge. Thanks for doing this.

cadquery/cq.py Show resolved Hide resolved
tests/test_cadquery.py Show resolved Hide resolved
@jmwright
Copy link
Member

jmwright commented Jul 9, 2020

@adam-urbanczyk Let me know whether you want to merge it, or whether I should.

@adam-urbanczyk
Copy link
Member Author

adam-urbanczyk commented Jul 9, 2020 via email

@jmwright
Copy link
Member

jmwright commented Jul 9, 2020

Ok, merging.

@jmwright jmwright merged commit bacd459 into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polar array support with changing orientation
2 participants