-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polarArray with object rotation #395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 93.44% 93.46% +0.01%
==========================================
Files 19 19
Lines 4989 5004 +15
Branches 509 514 +5
==========================================
+ Hits 4662 4677 +15
Misses 205 205
Partials 122 122
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam-urbanczyk As long as the two things I marked were intentional changes, I think this is ready to merge. Thanks for doing this.
@adam-urbanczyk Let me know whether you want to merge it, or whether I should. |
Feel free to merge.
…On Thu, Jul 9, 2020, 10:10 PM Jeremy Wright ***@***.***> wrote:
@adam-urbanczyk <https://github.com/adam-urbanczyk> Let me know whether
you want to merge it, or whether I should.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#395 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKVOYWKRX4Y7WQFPVNXWFLR2YP3PANCNFSM4OVJH23A>
.
|
Ok, merging. |
This will resolve #118