Type annotations for shapes

[adam-urbanczyk]

No description provided.

[adam-urbanczyk]

I think I'm done. Enough of MyPy for quite some time, but I hope it will be beneficial in the long run.

[codecov]

Codecov Report

Merging #391 into master will decrease coverage by 0.03%.
The diff coverage is 94.39%.

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   93.42%   93.38%   -0.04%     
==========================================
  Files          19       19              
  Lines        4925     4976      +51     
  Branches      510      508       -2     
==========================================
+ Hits         4601     4647      +46     
- Misses        204      206       +2     
- Partials      120      123       +3     

Impacted Files	Coverage Δ
cadquery/cq.py	87.51% <84.21%> (+0.05%)	⬆️
cadquery/occ_impl/shapes.py	90.14% <96.17%> (-0.20%)	⬇️
cadquery/occ_impl/geom.py	88.81% <100.00%> (+0.02%)	⬆️
tests/test_cadquery.py	98.93% <100.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd75dcb...97f0dac. Read the comment docs.

[jmwright]

I think it looks good. Thanks for doing this.

[adam-urbanczyk]

One question @jmwright : I fixed CombinedCenterOfBoundBox (it was relying on a method that did not exist) but maybe it is better to completely remove it? No one ever complained about it not working so I guess is is effectively dead.

[jmwright]

I'd kind of like to keep it. That's because I've implemented versions of something similar in other apps. I don't think I ever knew that it existed in CQ.

[adam-urbanczyk]

Alright, I'll add a test for it then.

[adam-urbanczyk]

Done, merging.