Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more introduction to Workplanes in the docs #386

Merged

Conversation

marcus7070
Copy link
Member

I was trying to help a user (here) and I wanted to point them to somewhere in our docs where they could get the concept of a workplane and how solids are created relative to a workplane. I think they hadn't encountered the concept of workplanes before. I realised the docs don't say too much about the concept of workplanes (probably because back when they were written the link to FreeCAD was much stronger, so it was assumed knowledge). So I've added some more words to the docs. Do you think they help? I try to be brief because I know docs with too many words won't be read at all.

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files          19       19           
  Lines        4847     4847           
  Branches      483      483           
=======================================
  Hits         4523     4523           
  Misses        210      210           
  Partials      114      114           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1133f...75deeb5. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Thanks @marcus7070 , it does look useful.

@adam-urbanczyk
Copy link
Member

Small docs modification, so just merging.

@adam-urbanczyk adam-urbanczyk merged commit 02a8549 into CadQuery:master Jun 23, 2020
@marcus7070 marcus7070 deleted the marcus7070/workplane-docs branch June 23, 2020 20:47
@jmwright
Copy link
Member

Yes, thanks @marcus7070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants