-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix of inertia #1460
Add matrix of inertia #1460
Conversation
Could you run black form this repo https://github.com/CadQuery/black (or 19.10b0) on your changes? |
Sorry about the different formatting style, it should be better now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1460 +/- ##
==========================================
+ Coverage 94.35% 94.42% +0.07%
==========================================
Files 28 28
Lines 5809 5778 -31
Branches 993 983 -10
==========================================
- Hits 5481 5456 -25
+ Misses 197 194 -3
+ Partials 131 128 -3 ☔ View full report in Codecov by Sentry. |
The test has been updated. The implementation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kmarchais
This pull request introduces the implementation of the inertia matrix.
As indicated in issue #1453, this functionality is already accessible in OCP.
List[List[float]]
.This is my first PR here, I will be happy to have any suggestion to improve the code changes.
Apparently the tests are failing (even on master for me) on
tests/test_cadquery.py::TestCadQuery::testSweep
.