Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parenthesis bug in _isCoPlanar function #1451

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Fix parenthesis bug in _isCoPlanar function #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
023f287
Add test demonstrating parenthesis bug
egrim Nov 30, 2023
a72f46e
Fix parenthesis bug in `_isCoPlanar` function
egrim Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cadquery/cq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ def _isCoPlanar(f0, f1):
return False

# test if p1 is on the plane of f0 (offset of planes)
return abs(n0.dot(p0.sub(p1)) < self.ctx.tolerance)
return abs(n0.dot(p0.sub(p1))) < self.ctx.tolerance

def _computeXdir(normal):
"""
Expand Down
4 changes: 4 additions & 0 deletions tests/test_cadquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,6 +1613,10 @@ def testMultiFaceWorkplane(self):
self.assertAlmostEqual(o.y, 0.0, 3)
self.assertAlmostEqual(o.z, 0.5, 3)

# Test creation with non-co-planar faces fails
with raises(ValueError):
w = s.faces("+Y").workplane()

def testTriangularPrism(self):
s = Workplane("XY").lineTo(1, 0).lineTo(1, 1).close().extrude(0.2)
self.saveModel(s)
Expand Down