Skip to content

Fix typo - #1176

Merged
adam-urbanczyk merged 8 commits into
CadQuery:masterfrom
tkoyama010:patch-2
Dec 2, 2022
Merged

Fix typo#1176
adam-urbanczyk merged 8 commits into
CadQuery:masterfrom
tkoyama010:patch-2

Conversation

@tkoyama010

Copy link
Copy Markdown
Contributor

Fix a small typo.

@codecov

codecov Bot commented Oct 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1176 (fd4d263) into master (083e5da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fd4d263 differs from pull request most recent head e80ad12. Consider uploading reports for the commit e80ad12 to get more accurate results

@@           Coverage Diff           @@
##           master    #1176   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          26       26           
  Lines        5411     5412    +1     
  Branches      918      919    +1     
=======================================
+ Hits         5087     5088    +1     
  Misses        193      193           
  Partials      131      131           
Impacted Files Coverage Δ
cadquery/assembly.py 96.56% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lorenzncode lorenzncode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, what about the following?:
L99 "lets step through it"
L159 "lets break it down a bit"

The subsection capitalization is inconsistent in this section. In some cases title case is used and others sentence case. The capitalization is wrong either way of "A" in the line directly above this change.
"Start With A single, simple Plate"

For the subsections, I'd suggest:
Prerequisites: conda + CQ-editor running from an environment (no change)
What we'll accomplish (no change)
Start with a single, simple plate
Add the holes
More holes
... no change to remaining subsection titles.

@adam-urbanczyk

Copy link
Copy Markdown
Member

Should I just merge this PR, or are you still working on it?

@hiaselhans

Copy link
Copy Markdown
Contributor

I don't have a vote here, but in order to keep the PR section clean, i would just merge it and hope for @lorenzncode to apply his changes at a later point :)

@tkoyama010

Copy link
Copy Markdown
Contributor Author

Sorry for the late reply. It is ready for merge.

@lorenzncode lorenzncode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all instances of the typo in the file.

@adam-urbanczyk

Copy link
Copy Markdown
Member

Thanks @tkoyama010 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants