Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly export: do not add leaf component when shapes is empty (#993) #1157

Merged
merged 13 commits into from
Jan 14, 2023
Merged

Assembly export: do not add leaf component when shapes is empty (#993) #1157

merged 13 commits into from
Jan 14, 2023

Commits on Sep 18, 2022

  1. Assembly export: do not add leaf component when shapes is empty (CadQ… 

    …uery#993)
    @lorenzncode
    lorenzncode committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    44054d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Merge branch 'master' into assy_993

    @lorenzncode
    lorenzncode committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    6af3ea6 View commit details
    Browse the repository at this point in the history

  2. Add test to validate number of leaf nodes in OCAF data

    @lorenzncode
    lorenzncode committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    1fac232 View commit details
    Browse the repository at this point in the history

  3. mypy fix

    @lorenzncode
    lorenzncode committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    d42a6d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Remove len call

    @lorenzncode
    lorenzncode committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    bc6cf2a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Merge branch 'master' into assy_993

    @lorenzncode
    lorenzncode committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    f1340af View commit details
    Browse the repository at this point in the history

  2. Improve assembly makeCompound and color handling for glTF, STEP 

    * Create single compound for multiple instances of same shape
* Fix glTF, STEP export color handling
* Special handling for part names and naming convention for multiple instances of a shape
* Change default glTF mesh tolerance to be consistent with other formats
* Allow creation of default Color (when color name, tuple values unspecified)
* Add tests of assembly colors including STEP export
    @lorenzncode
    lorenzncode committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    67a817b View commit details
    Browse the repository at this point in the history

  3. Fix tests on Python 3.8

    @lorenzncode
    lorenzncode committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    711ffac View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Apply changes from code review 

    * Add assembly children recursively
* Remove STEP part naming special handling
* Add glTF test to check for missing mesh
    @lorenzncode
    lorenzncode committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5920f0d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into assy_993

    @adam-urbanczyk
    adam-urbanczyk authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    97b3af5 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Extend copy

    @adam-urbanczyk
    adam-urbanczyk authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    3938b55 View commit details
    Browse the repository at this point in the history

  2. Refactor to use the updated copy method

    @adam-urbanczyk
    adam-urbanczyk authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    384305b View commit details
    Browse the repository at this point in the history

  3. Black fix

    @adam-urbanczyk
    adam-urbanczyk authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    040bcfc View commit details
    Browse the repository at this point in the history