Add Workplane.placeSketch to the API Reference documentation - #1056
Merged
Conversation
This is an important method for combining the sketch and 3D workflows, therefore it should be included in the API reference to improve discoverability
GandalfDG
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 40 40
Lines 9407 9407
Branches 1248 1248
=======================================
Hits 9061 9061
Misses 204 204
Partials 142 142 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
|
@lorenzncode @adam-urbanczyk Any objects to this being added to the API reference? |
lorenzncode
approved these changes
May 10, 2022
Contributor
Author
|
This is a minor change, but I've also dug a little further into the documentation as I was noticing a lot of broken links to methods. I've put those changes into PR #1058 |
jmwright
self-requested a review
May 31, 2022 23:45
jmwright
approved these changes
May 31, 2022
jmwright
left a comment
jmwright
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for the contribution @GandalfDG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an important method for combining the sketch and 3D workflows,
therefore it should be included in the API reference to improve discoverability
resolves #1052