Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workplane.placeSketch to the API Reference documentation #1056

Merged
merged 2 commits into from
May 31, 2022

Conversation

GandalfDG
Copy link
Contributor

This is an important method for combining the sketch and 3D workflows,
therefore it should be included in the API reference to improve discoverability

resolves #1052

This is an important method for combining the sketch and 3D workflows,
therefore it should be included in the API reference to improve discoverability
@GandalfDG GandalfDG changed the title Documentation Add Workplane.placeSketch to the API Reference documentation Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1056 (6ed1e09) into master (6ae673a) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ed1e09 differs from pull request most recent head 81de352. Consider uploading reports for the commit 81de352 to get more accurate results

@@           Coverage Diff           @@
##           master    #1056   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9407     9407           
  Branches     1248     1248           
=======================================
  Hits         9061     9061           
  Misses        204      204           
  Partials      142      142           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jmwright
Copy link
Member

jmwright commented May 9, 2022

@lorenzncode @adam-urbanczyk Any objects to this being added to the API reference?

@GandalfDG
Copy link
Contributor Author

This is a minor change, but I've also dug a little further into the documentation as I was noticing a lot of broken links to methods. I've put those changes into PR #1058

@jmwright jmwright self-requested a review May 31, 2022 23:45
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution @GandalfDG

@jmwright jmwright merged commit e28547e into CadQuery:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

placeSketch method is missing from the API Reference
3 participants