Skip to content

Commit

Permalink
Merge pull request #387 from CadQuery/BuildCurves3d-fix
Browse files Browse the repository at this point in the history
Better BuildCurves3d_s parameters in makeHelix
  • Loading branch information
jmwright authored Jun 24, 2020
2 parents e51b58e + 4a264d2 commit 56046ef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cadquery/occ_impl/shapes.py
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,7 @@ def makeHelix(

# 4. Convert to wire and fix building 3d geom from 2d geom
w = BRepBuilderAPI_MakeWire(e).Wire()
BRepLib.BuildCurves3d_s(w)
BRepLib.BuildCurves3d_s(w, 1e-6, MaxSegment=2000) # NB: preliminary values

return cls(w)

Expand Down

0 comments on commit 56046ef

Please sign in to comment.