applyToEachFace(..) - simplified each(..) for faces #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed first callback of apply_to_each_face(..) so that it not only determines x axis direction but also creates face workplane so that it can be extended in the future - Registered apply_to_each_face as a Workplane method Code not fully cleaned up. No type hints yet. And no comments. Did not test installer
- Updated examples so that they can work in CQ-editor more than once - Formatted examples with Black - Moved images to images directory
Member
|
@fedorkotov Is this ready for review? |
Contributor
Author
|
@jmwright Yes, it is ready |
Contributor
Author
|
Black found no issues but the action fails with |
jmwright
reviewed
Apr 30, 2021
Member
jmwright
left a comment
jmwright
left a comment
There was a problem hiding this comment.
The apply-to-each-face submodule seems to be a dead end. If I try to update the submodules for your branch, git refuses to do it.
Contributor
Author
|
Sorry. Can't remember how and why did I add this |
Contributor
Author
|
A friendly ping for project maintainers. Just to make sure that this pull request is not forgotten. If nobody has the time for review, it's Ok. |
Member
|
I'll start my review today. |
marcus7070
requested changes
May 12, 2021
Member
marcus7070
left a comment
marcus7070
left a comment
There was a problem hiding this comment.
Aside from my comment about reloading the module, this all looks great to me!
marcus7070
approved these changes
May 12, 2021
Member
|
@fedorkotov Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin simplifies using
Workplane.each(..)on faces. To use each you have to select workplane coordinate system for each face before building your geometry.Workplane.applyToEachFace()function provided by this plugin separates tasks of choosing face coordinate system and actually building new geometry and provides a few built in ways of choosing coordinate system thatare good enough in many cases.
See also CadQuery/cadquery#713