fix(flow): refactor flow naming to remove interfering with mgm processing order - #5095
Draft
Y4nnikH wants to merge 4 commits into
Draft
fix(flow): refactor flow naming to remove interfering with mgm processing order#5095Y4nnikH wants to merge 4 commits into
Y4nnikH wants to merge 4 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To preserve the naming hierarchy for new flow objects, we currently order the to-be-synced managements accordingly during processing, so names get assigned on first come first serve basis. But we need e.g. sub managements to be synced after their super management, for flow objects derived from global objects to be available. This may not be compatible.
So instead, we now add new flow objects without name during management processing and then assign the names with a final call to a naming function, after all managements have been synced.
This also allows a refactoring of some flow naming logic in the ui to use the same function.
Need to test if this affects performance or existing functionality.