feat(importer): add generic firewall import#4923
Open
Y4nnikH wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds database/device-type support and importer plumbing for a new “Generic Firewall” management/gateway type intended for importing normalized configurations, and adjusts the Azure 2022 ff module toward normalized-config-only operation.
Changes:
- Introduces
fw_modules/genericwith aGenericFirewallCommon.get_config()path intended for normalized config input. - Updates importer module dispatch in
roles/importer/files/importer/common.pyto include the generic module (and updates Azure 2022 fffwcommon.pybehavior). - Adds new
stm_dev_typrows (upgrade + creation seed), bumps product version to 9.1.18, and updates revision history.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/importer/files/importer/fw_modules/generic/fwcommon.py | New generic fwcommon entrypoint for normalized-only import. |
| roles/importer/files/importer/fw_modules/generic/init.py | Package marker for the new generic importer module. |
| roles/importer/files/importer/fw_modules/azure2022ff/fwcommon.py | Replaces NotImplemented with a normalized-config-only get_config() stub. |
| roles/importer/files/importer/common.py | Adds generic module dispatch (and should also wire in Azure + fix generic package-name match). |
| roles/database/files/upgrade/9.1.18.sql | Adds new device types for generic firewall management/gateway on upgrade. |
| roles/database/files/sql/creation/fworch-fill-stm.sql | Seeds generic device types for fresh installs; adjusts some stm_dev_typ inserts to include dev_typ_is_multi_mgmt. |
| inventory/group_vars/all.yml | Bumps product_version to 9.1.18. |
| documentation/revision-history.md | Adds 9.1.18 release notes entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4870