fix(UI): Freeze/Crash#4893
Draft
SolidProgramming wants to merge 15 commits into
Draft
Conversation
…her services/components
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ This PR has the possibility to crash anything UI related so please test thoroughly ❗
This fixes the disposing that happens when browsers go into data/resource saving modes and closing the connection to the middleware (Edge default 1 hour). The UI is then not able to refresh the JWT when this happens. The Mainlayout will dispose but the sidebar which is included in mainlayout wasn't disposed correctly and that lead to UI crash because of the events from sidebar<->DomEventManager kept firing even on disposed UI.
Closing #4860